Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlights are shown even if find widget is closed #145866

Closed
sandy081 opened this issue Mar 23, 2022 · 5 comments · Fixed by #146199
Closed

Highlights are shown even if find widget is closed #145866

sandy081 opened this issue Mar 23, 2022 · 5 comments · Fixed by #146199
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget verified Verification succeeded
Milestone
April 2022

Comments

@sandy081
Copy link
Member

Testing #145629

image
@meganrogge
Copy link
Contributor

The widget is open in your screenshot

@meganrogge meganrogge added the info-needed Issue requires more information from poster label Mar 23, 2022
@meganrogge
Copy link
Contributor

Screen Shot 2022-03-23 at 12 02 34 PM

@sandy081
Copy link
Member Author

Wrong screenshot again. Here you go

image

@meganrogge
Copy link
Contributor

Thanks, but I cannot repro this - could you pls attach a gif?

@sandy081
Copy link
Member Author

  • Have a split terminal
  • Focus in second terminal and open find widget and search for some text to show highlights
  • Focus in first terminal and press escape

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget and removed info-needed Issue requires more information from poster labels Mar 25, 2022
@meganrogge meganrogge added this to the April 2022 milestone Mar 25, 2022
meganrogge added a commit that referenced this issue Mar 28, 2022
@meganrogge
fix #145866
839d2b0
@meganrogge meganrogge mentioned this issue Mar 28, 2022
Merged
@sandy081 sandy081 added the verified Verification succeeded label Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget verified Verification succeeded
Projects
None yet
Milestone
April 2022
4 participants
@Tyriar @sandy081 @meganrogge and others