Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move profile handling from TerminalService into new TerminalProfileService #136056

Closed
Tracked by #136065
Tyriar opened this issue Oct 28, 2021 · 0 comments · Fixed by #136131
Closed
Tracked by #136065

Move profile handling from TerminalService into new TerminalProfileService #136056

Tyriar opened this issue Oct 28, 2021 · 0 comments · Fixed by #136131
Assignees
@meganrogge
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Milestone
November 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2021

Move management of terminal profiles (get, update) to it's own small/testable service. Goal is to reduce size of TerminalService and improve testing around profiles.

  • Have TerminalProfileResolverService depend on TerminalProfileService
  • Write header comment for ITerminalProfileResolverService and ITerminalProfileService explaining their purpose
  • Move TerminalInstance.showProfileMigrationNotification into TerminalProfileService
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Oct 28, 2021
@Tyriar Tyriar added this to the November 2021 milestone Oct 28, 2021
This was referenced Oct 28, 2021
Closed
Closed
meganrogge added a commit that referenced this issue Oct 29, 2021
@meganrogge
work on #136056
99098e1
@meganrogge meganrogge mentioned this issue Oct 29, 2021
Merged
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Create TerminalProfileService microsoft/vscode
3 participants
@Tyriar @meganrogge and others