Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate circular dependency between TerminalInstance and TerminalInstanceService #136062

Closed
Tracked by #136065
Tyriar opened this issue Oct 28, 2021 · 0 comments · Fixed by #137464
Closed
Tracked by #136065

Investigate circular dependency between TerminalInstance and TerminalInstanceService #136062

Tyriar opened this issue Oct 28, 2021 · 0 comments · Fixed by #137464
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Milestone
November 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2021

  • Original intent of TerminalInstanceService was purely so TerminalInstance didn't depend on TerminalService
  • Need to look into what depends on TerminalInstanceService.createInstance/onDidCreateInstance
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Oct 28, 2021
@Tyriar Tyriar added this to the November 2021 milestone Oct 28, 2021
@Tyriar Tyriar mentioned this issue Oct 28, 2021
Closed
7 tasks
Tyriar added a commit that referenced this issue Nov 18, 2021
@Tyriar
Remove unused interface members from ITerminalInstanceService
1331a41 
Part of #136062
Tyriar added a commit that referenced this issue Nov 18, 2021
@Tyriar
Move get xterm ctor out of instance service
9d7519e 
Part of #136062
Tyriar added a commit that referenced this issue Nov 18, 2021
@Tyriar
Consolidate convertProfileToShellLaunchConfig into instance service
7d3408d 
Part of #136062
@Tyriar Tyriar mentioned this issue Nov 18, 2021
Merged
Tyriar added a commit that referenced this issue Nov 18, 2021
@Tyriar
Break circular dependency between term instance/instance service
db65778 
Fixes #136062
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Refactor TerminalInstanceService microsoft/vscode
3 participants
@Tyriar @meganrogge and others