Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create terminal smoke test suite #136064

Closed
4 of 21 tasks
Tyriar opened this issue Oct 28, 2021 · 1 comment
Closed
4 of 21 tasks

Create terminal smoke test suite #136064

Tyriar opened this issue Oct 28, 2021 · 1 comment
Assignees
Labels
debt Code quality issues plan-item VS Code - planned item for upcoming terminal Integrated terminal issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2021

The terminal used to have 1-2 simple smoke tests which just echoed text and checked it. We should look into creating more involved smoke tests and potentially exposing TerminalService to the smoke tests if that would make testing easier.

Problem areas we should look at covering:

  • Perfect layout size (terminal-layout.test.ts)
    • Cells aren't cut off
    • Perfect scroll bar positioning
    • Toggle size to content width
  • Profiles (terminal-profiles.test.ts)
    • New with profile command is very complex - unit tests
  • Tabs list (terminal-tabs.test.ts)
    • Drag and drop
    • Unsplit
  • Terminal editors (terminal-editors.test.ts)
    • Drag and drop between panel and editor
    • Move commands
  • Persistence (terminal-persistence.test.ts)
    • Local reconnection
    • Remote reconnection
    • Local revive
    • Remote revive
    • Icons, names
    • Restore order
    • Detach session isn't working - also reattach after kind of tests moving across windows
  • Multi-root scenarios?
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Oct 28, 2021
@Tyriar Tyriar added this to the November 2021 milestone Oct 28, 2021
@Tyriar Tyriar added the plan-item VS Code - planned item for upcoming label Oct 28, 2021
Tyriar added a commit that referenced this issue Nov 9, 2021
Tyriar added a commit that referenced this issue Nov 9, 2021
Tyriar added a commit that referenced this issue Nov 19, 2021
This was causing detach to kill procs immediately

Part of #136064
Tyriar added a commit that referenced this issue Nov 23, 2021
This was causing detach to kill procs immediately

Part of #136064
Tyriar added a commit that referenced this issue Nov 23, 2021
Tyriar added a commit that referenced this issue Nov 23, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Nov 29, 2021

Main goals of this have been accomplished. Layout tests, drag and drop and multi-window tests are a bit tricky to accomplish on smoke tests and mostly test what's already tested.

Multi-root tests deferred in #137747

@Tyriar Tyriar closed this as completed Nov 29, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues plan-item VS Code - planned item for upcoming terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants