-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide the ability to specify dependencies on a per-platform basis #136231
Comments
Not sure "extensionDependencies": [
{
"id": "ms-python.vscode-pylance",
"platforms": ["-web"]
},
"dbaeumer.vscode-eslint"
]
I agree that it is not recommended to have different package.jsons per platform. But I do not understand how settings sync will uninstall Pylance on desktop? Settings Sync does not respect extension pack or dependencies. It just sync extension by extension. Can you please explain more why python extension does not want pylance to be part of python in web? What are the consequences of having it? CC: @alexdima |
It's not uninstall, it's re-installing Pylance when a user may have uninstalled it on desktop perviously. So the scenarios I'm concerned about is:
|
Ah I see. So Python has hard dependency on Pylance in web. In that case, Settings Sync will always brings in Pylance on desktop irrespective of how you define dependencies. |
Hi, Any news about this? I'm facing a similar issue once my Pascal extension depends on my Pascal Formatter extension (defined using I'm trying to adapt my Pascal extension to work on the web, and because the Formatter wouldn't be available on the web, it makes no sense to install/updated it either. Thank you |
@alefragnani so far no news here. Sorry. |
@isidorn thanks for the update. No Pascal on the web, for now 😄 |
Now that |
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
It would be great if an extension's depedencies could be platform-specific. For instance, the Python extension has Pylance as an optional dependency. But on the web, having Pylance be optional doesn't make sense as it provides all features for the Python extension on that platform.
We contemplated creating a custom package.json for the web platform, but Settings Sync in this situation would lead to an issue for users who chose to uninstall Pylance on desktop.
The text was updated successfully, but these errors were encountered: