Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Support GitHub.dev #461

Open
alefragnani opened this issue Aug 30, 2021 · 14 comments · Fixed by #524
Open

[FEATURE] - Support GitHub.dev #461

alefragnani opened this issue Aug 30, 2021 · 14 comments · Fixed by #524
Assignees
Labels
depends on Depends on issues from VS Code enhancement
Milestone

Comments

@alefragnani
Copy link
Owner

https://github.com/microsoft/vscode-docs/blob/vnext/api/extension-guides/web-extensions.md

@isidorn
Copy link

isidorn commented Nov 22, 2021

This would be super nice to have 👏
Are there a lot of node dependencies that you have?
Is there something we or the community could help with?

Thanks!

@alefragnani
Copy link
Owner Author

Hi @isidorn ,

I thought it would be, but I don’t see too much upvotes here so, I guess we may be minority 😆 . That’s the main reason I didn’t update the extension yet. Also because I don’t use github.dev nor vscode.dev as much as I would like to, mostly because it lacks debugging.

There are less dependencies today, because I already made a clean up while refactoring the extension to support remotes a few releases ago. So a bunch of fs and path references where replaced by workspace.fs and Uri. But, a few dependencies remains, like os.platform and path.

The Web Extensions guide and the sample projects gives a good overview on what have to be made. In fact I remember asking for a more focused updating existing extension documentation back then, and the oficial documentation received that. Thanks!

BTW, thanks for the kindly offer. If the extension wasn’t closed source, I would definitely accept a PR.

I hope to find some free time next month.

Thank you

@isidorn
Copy link

isidorn commented Nov 29, 2021

@alefragnani thanks for the clarification! And good news that there are not a lot of dependencies today.
Let's see how it goes in a couple of months once you find time :)

@nova77
Copy link

nova77 commented Jan 6, 2022

I'd really love to have bookmarks enabled for the web version as well. It's not just for github.dev, but for whoever runs vscode in a web environment.

@alefragnani
Copy link
Owner Author

I'm trying, but facing debug and test issues, unfortunately

Probably some minor issue, I hope

@alefragnani
Copy link
Owner Author

It seems the "out of sync" issue where know since November 2021 (they marked as duplicate of microsoft/vscode#136242), but the fix will only be available on January 2022 release.

@alefragnani alefragnani added the depends on Depends on issues from VS Code label Jan 6, 2022
@bamurtaugh
Copy link

Hi @alefragnani! I was wondering if you might have any new thoughts on this, now that the January 2022 VS Code release is out? We're happy to discuss if you have questions or feedback. Thank you!

@alefragnani
Copy link
Owner Author

Hi @bamurtaugh ,

I just played with this last week and could confirm both issues reported above has indeed been fixed so, I could finally update some of my (simpler) extensions.

I do monthly updates of my extensions, so I’m planning the first ones to be available next month. I’m not sure this one will be in the initial pack, but I would like to.

BTW, at least two of my extensions can’t support vscode.dev right now, because depend on some VS Code issue:

As I commented above, I don’t use vscode.dev that much. But it doesn’t mean I don’t want to support it. Right the opposite, because I hope end users will.

The main reason for me to use VS Code on the web is take advantage of my iPad as a development machine, which means Codespaces, but it still lacks support for debugging VS Code extensions, as you can see here microsoft/vscode#118383. And because Codespaces doesn’t work properly (for me), it is hard to keep pushing the extensions forward or looking for workarounds. But I have hope that these issues should be fixed in the near future.

Thank you

@bamurtaugh
Copy link

Thanks for the updates and insights, @alefragnani! It's exciting to hear about the extension updates, and the info you've shared makes sense.

Please let me know if we can help in any other way.

@alefragnani alefragnani removed the depends on Depends on issues from VS Code label Mar 12, 2022
@alefragnani
Copy link
Owner Author

spoiler alert 😁

Screen Shot 2022-03-13 at 14 31 32

@alefragnani alefragnani self-assigned this Mar 24, 2022
@alefragnani alefragnani added this to the March 2022 milestone Mar 24, 2022
alefragnani added a commit that referenced this issue Mar 25, 2022
@alefragnani
Copy link
Owner Author

Reopening, because I noticed an issue while opening different local folders

Depends on microsoft/vscode#146868

@alefragnani
Copy link
Owner Author

Just like my other Numbered Bookmarks extension alefragnani/vscode-numbered-bookmarks#130 (comment)

I'll postpone this feature, with no ETA.

Not only because the activation issue described above (which I could fix in the desktop), but also the difficulty in debug on the web, specially the out of sync breakpoints.

I'll come back to this regularly, but it is not a priority.

@Nu11u5
Copy link

Nu11u5 commented May 18, 2022

Hoping this feature can be made to work on vscode.dev. Regarding the breakpoint sync issues, sometimes the good-old debugger; statement is still useful.

@alefragnani
Copy link
Owner Author

The breakpoint issue is not happening anymore, thankfully, but the difficulty to debug is making it impossible to understand why/how to manage the so called default multi-root workspace that vscode.dev has.

I'm still looking for vscode.dev news/updates, and I'll retry/retest it from time to time, but it isn't a priority anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on Depends on issues from VS Code enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants