Call stack items aren't opening tabs with correct contents

[eamodio]

While debugging extensions, if I stop at a break point and try to walk back up the call stack, the tabs that get opened from the call stack view have the correct tab name, but don't initially have the correct contents. But if you switch to a different tab and then back, the proper contents get shown.

This started quite recently (in insiders).

/cc @connor4312 @bpasero

[roblourens]

I saw this yesterday but didn't have time to debug. Nothing has changed in debug's end. Any idea @bpasero @lramos15?

[bpasero]

No idea from my end, would be good to have a simple repro.

[bpasero]

One thing I did change recently, not sure whether it could be the reason though: when you call openEditor and there is another call right after that would cancel the first one, undefined is returned. Previously we would return the editor pane even though the opening was cancelled.

Refs: 6ed67dd

[weinand]

I couldn't reproduce this.
Does the problem reproduce if you run VS Code without extensions?

[rchiodo]

I can reproduce this consistently. You just need an item in the callstack that is from a file that's different from the topmost item.

[rchiodo]

Repro steps for me

• Disable all extensions
• Clone https://github.com/microsoft/vscode-extension-samples.git
• Open the tree-view sample
• Stick a breakpoint in jsonOutline.ts::refresh()
• Start debugging
• Open a json file
• Breakpoint should hit
• Click on the extension.activate call frame

It activates the tab, but the contents are from the jsonOutline.ts file:

[weinand]

@rchiodo thanks for the steps, now I can reproduce!

(without your detailled steps I was trying a web-packed extension which only has one underlying *.js file but maps to many *.ts files).

In my case (on macOS) I do not see the wrong contents, but no contents at all:

[rchiodo]

/verified. Opened tabs are correct.