Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant requests are made to Marketplace #139013

Closed
sandy081 opened this issue Dec 13, 2021 · 2 comments
Closed

Redundant requests are made to Marketplace #139013

sandy081 opened this issue Dec 13, 2021 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extensions Issues concerning extensions verified Verification succeeded
Milestone
November 2021 Rec...

Comments

@sandy081
Copy link
Member

sandy081 commented Dec 13, 2021 •
edited
Loading

Steps to Reproduce:

  • Open VS Code (Empty window)
    • Use empty extensions directory (better to open on fresh user-data-dir using --user-data-dir arg and fresh extensions dir using --extensions-dir arg)
    • Open extensions view and hide recommendations view
  • Install pre-release versions of following extensions
    • github.vscode-pull-request-github
    • andreweinand.mock-debug
  • Open network tab in developer tools and filter for extensionsQuery request
  • Reload VS Code Window

🐛 It is expected to make only 2 requests to Marketplace but 2 additional requests one per each pre-release version are made.

Same can also be reproduced in VS Code insiders, but at step 2 - you have to install release versions instead of pre-release versions.
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions candidate Issue identified as probable candidate for fixing in the next release labels Dec 13, 2021
@sandy081 sandy081 added this to the November 2021 Recovery milestone Dec 13, 2021
@sandy081 sandy081 self-assigned this Dec 13, 2021
@sandy081
Copy link
Member Author

Reopening for recovery

@sandy081 sandy081 reopened this Dec 13, 2021
sandy081 added a commit that referenced this issue Dec 13, 2021
@sandy081
Fix #139013
8dd2724
@sandy081 sandy081 mentioned this issue Dec 13, 2021
Merged
sandy081 added a commit that referenced this issue Dec 15, 2021
@sandy081
Fix #139013
c5a4e53
@sandy081 sandy081 mentioned this issue Dec 15, 2021
Merged
sandy081 added a commit that referenced this issue Dec 15, 2021
@sandy081
Merge pull request #139176 from microsoft/sandy081/fix139013
8e7b278 
Bring back the fix for #139013
@deepak1556
Copy link
Collaborator

Closing for verification.

@isidorn isidorn added the verified Verification succeeded label Dec 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
November 2021 Recovery 2
Development

No branches or pull requests
4 participants
@deepak1556 @isidorn @sandy081 and others