Word based suggestions not working in functions/quotes

[kanlukasz]

Does this issue occur when all extensions are disabled?:
Yes

VS Code and OS Version:

Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19044

Steps to Reproduce:

[jrieken]

Please provide all files in source, no GIFs!

Also retry without extensions enabled. Select 'Extensions View > ... > Disable all Installed Extensions' and try again. Thanks.

[kanlukasz]

Steps to Reproduce:

1. Download fresh VSCode portable from official source

2. Unpack, create empty data directory, run

3. Select Extensions View > ... > Disable all Installed Extensions (either way, nothing is installed because it's a fresh install)

4. Reload Window

5. Open empty folder

6. Create two files - from.php & to.php

7. The contents of the from.php file:

<?php

$name = 'Bartholomew';

function getName(string $name): string
{
    return $name;
}

8. The contents of the to.php file:

<h1></h1>

<?php

getName('');

$name2 = '';

9. VSCode Settings:

{
    "editor.quickSuggestions": {
        "other": true,
        "comments": true,
        "strings": true
    },
    "editor.wordBasedSuggestionsMode": "allDocuments"
}

10. Now let's open and leave both files open and try to start typing the name 'Bartholomew' in the blanks in the file to.php.
    As you will notice, autosuggestion will work between the h1 tag, but will not work in getName(''); function and in the $name2 = ''; variable

---

Above I have written everything in the form of text and sources, but for the sake of clarity, I am attaching a short GIF with the result of these actions again:

[jrieken]

Select Extensions View > ... > Disable all Installed Extensions (either way, nothing is installed because it's a fresh install)

No, you need to use --extensions-dir <folder> because user data is separate from extensions. So, please do that and confirm if you still see this. I don't, e.g I don't see Bartholomew being suggested inside the h1-tag nor the string. This is likely because another extension provides completions which are then all filtered. In that case you don't see textual suggestion (see #21611)

[kanlukasz]

I'm not sure if I understand correctly what you mean user data is separate from extensions.

I run VSCode from command line with:
"C:\Users\username\Desktop\vscode\Code.exe" --extensions-dir="C:\Users\username\Desktop\vscode\data\extensions"
but nothing has changed

---

---

---

PS.:

My portable installation looks like this:

---

In the data directory that I created, I have:

The above directories were created automatically

---

Extenions directory is empty:

---

If you want, I can install VSCode using the System Installer on another computer that has never had VsCode installed and check it again 🤷‍♂️

[jrieken]

Sorry, I misread the very first step. You are doing it right but I still don't understand why I am not seeing any word suggestions...

[kanlukasz]

Do your VSCode settings look the same as mine? I mean:

{
    "editor.quickSuggestions": {
        "other": true,
        "comments": true,
        "strings": true
    },
    "editor.wordBasedSuggestionsMode": "allDocuments"
}

[jrieken]

Yes, this is what I see ⬇️ So, basically I always get suggestions from the built-in php extension and that mutes word bases suggestions

Screen.Recording.2022-01-05.at.11.51.13.mov

[kanlukasz]

Thanks for sharing the screen.
Note that you are typing Bar or bart between h1. I can confirm that it doesn't actually prompt in this case, but if you type Bart it will work

See on my screen below:

[jrieken]

Note that you are typing Bar or bart between h1. I can confirm that it doesn't actually prompt in this case, but if you type Bart it will work

Thanks for clarifying - indeed with the bart prefix it works. It seems that the builtin php extension doesn't something with any shorter prefix which suppresses word based suggestions.

I wasn't always able to reproduce what you see but after starring at the code I found a race condition - sometimes snippets would suppress completions (which isn't meant to ever happen). I will push a change now and would ask you to try again with next/tomorrows insiders build

[jrieken]

@kanlukasz Can you give this a try this with VS Code Insiders?

[Ciantic]

This happened to me too, but it works in the insiders!

However it still shows those two #region things there, even though I have php.suggest.basic: false:

I don't know where it pulls those ones.

[jrieken]

Ok, thanks for clarifying. Closing. Too eager snippets are tracked here: #140039