Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File nesting increases time to render directories with many nests #140883

Closed
JacksonKearl opened this issue Jan 18, 2022 · 3 comments
Closed

File nesting increases time to render directories with many nests #140883

JacksonKearl opened this issue Jan 18, 2022 · 3 comments
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2022

Comments

@JacksonKearl
Copy link
Contributor

#6328

https://github.com/JacksonKearl/explorer-nesting-stress-test

xl/nested takes much longer to render with file nesting enabled. Impact is lessened by disabling file nest auto-expansions.

xl/flat is not significantly slower to render with nesting, though I have not collected proper numbers yet.
@JacksonKearl JacksonKearl self-assigned this Jan 18, 2022
@JacksonKearl JacksonKearl added file-explorer Explorer widget issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues bug Issue identified by VS Code Team member as probable bug labels Jan 18, 2022
@JacksonKearl JacksonKearl added this to the February 2022 milestone Feb 4, 2022
JacksonKearl pushed a commit that referenced this issue Feb 16, 2022
Add fast path for synchronously resolved children (nested children)
079a688 
ref #140883
JacksonKearl pushed a commit that referenced this issue Feb 16, 2022
Create a fast path for children that resolve sync
8ab21f7 
Ref #140883
@JacksonKearl JacksonKearl mentioned this issue Feb 16, 2022
Merged
@kieferrm kieferrm mentioned this issue Feb 16, 2022
Closed
81 tasks
JacksonKearl pushed a commit that referenced this issue Feb 17, 2022
Create a fast path for children that resolve sync (#143162)
563785e 
Ref #140883
@JacksonKearl
Copy link
Contributor Author

\closedWith 563785e

@joyceerhl joyceerhl added the verified Verification succeeded label Feb 25, 2022
@joyceerhl
Copy link
Contributor

joyceerhl commented Feb 25, 2022 •
edited
Loading

xl/nested takes a comparable amount of time to render with file nesting enabled, though there is a perceptible delay for both. However, I do also notice that the window becomes intermittently unresponsive after expanding xl/nested, e.g. when scrolling in the explorer. Is this known?

@JacksonKearl
Copy link
Contributor Author

Yeah, same thing happens with nesting disabled. There's an open issue somewhere for ways to reduce that (like streaming the dir contents).

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
3 participants
@JacksonKearl @joyceerhl and others