-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to launch on latest wl_roots due to Chromium bug #141964
Comments
/assign deepak1556 -meganrogge |
I have the exact same environment and observe the exact same issue. Very interested in a fix! |
Any news or work arounds one might be able apply to get this working? |
Still present in Arch Linux/sway-1.7/wlroots-0.15.0 + VSCode-1.64 |
On Arch you can use this workaround @heppu @elipp @ozls @akselaase |
@glanch yeah, did that for a while... While it pains me, I opted to just enable xwayland in sway for the time being, since I don't have any HiDPI screens in use... |
bumping electron to the latest 13.x release with the backport'd fix got stuff working again... but with vscode moving to electron v16 looks like we're now waiting for electron/electron#32603 to ship in a later release |
@glanch Thank you! I've been looking this blurry mess on xwayland and almost forgot how good the text actually looks. |
On arch using aur electron13-bin code-oss works. |
@emvidi At least on my end, using electron13-bin instead of the normal electron13 did not fix the issue. I am using Manjaro tho, but the packages should be mostly the same.
|
@major-mayer you don't need anymore the aur package, the arch electron13 package has been already updated. |
You are right, the version number is the same now. |
@major-mayer Which vscode package are you using? The |
I am using the regular Code - OSS package from the community repository (the one that you can call by executing |
Can confirm, latest package from the repo (as of 2022-03-03, |
Interestingly on my notebook (Manjaro - KDE) I still had Electron 13.6.8 installed and code-oss (1.64.2) worked fine in native Wayland mode. Edit: and after the upgrade of Electron13 and code it didn't work anymore. |
The current version of VSCode is based on electron 13.5.x, which doesn't include the patch for this issue. There's work going on to upgrade electron to 17.1.x ( #143223 ), after which the issue will hopefully be fixed. |
Then I guess the arch issue is that Vscode is packaged with an unsupported version of electron. |
On Fedora 34 the stable VSCode version launches fine with the Wayland flags but the latest insider version on Electron 17 is still broken.
EDIT: May be a different bug, since this happens also on Gnome Wayland |
For sway users on archlinux: |
The new version (1.66.0) doesn't launch for me. I am using sway. Now it's showing the same error as #141964 (comment) |
Yeah, same.. I switched back to stable VS Code because of this and I guess I'm staying on 1.65.x until this is fixed in insiders |
If so, #145527 is the PR for upgradation to electron 18. Will have to wait for another month. |
🎉 Fixed in the latests insiders |
Just downloaded |
Are you on Gnome? You need to change vscode settings to use custom titlebar. |
NVM! Just fixed by running |
Does this issue occur when all extensions are disabled?: Yes
visual-studio-code-bin 1.63.2-1
(899d46d)sway 1:1.7-1
andwlroots 0.15.0-4
Also happens on 1.64.0-insider (7b9e5c3)
Steps to Reproduce:
code --enable-features=UseOzonePlatform --ozone-platform=wayland --verbose
(last line printed by shell)
The issue is caused by this Chromium issue and is also reported to Electron and wlroots. The fix is backported to Electron 13 (electron/electron#32652).
This issue makes vscode unable to launch on Wayland. A workaround is running through XWayland, but that is blurry on hidpi-displays.
I can send a crash-dump on email if you wish.
The text was updated successfully, but these errors were encountered: