Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript debug launch broken #142199

Closed
murrellr opened this issue Feb 4, 2022 · 1 comment
Closed

Javascript debug launch broken #142199

murrellr opened this issue Feb 4, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@murrellr
Copy link

murrellr commented Feb 4, 2022

Issue Type: Bug

The January 2022 update broke debugging of Javascript using a file URL. This is one of my launch configurations:

		{
			"name": "aTB (172.23.165.1)",
			"request": "launch",
			"type": "pwa-chrome",
			"file": "${workspaceFolder}/_Battery/debug.html?172.23.165.1"
		},

When I start a debug session, Chrome used to start with this URL in the address bar:

file:///C:/workspace/_Battery/debug.html?172.23.165.1

Now it starts with this URL and reports "Your file couldn't be accessed". I have to manually change the "%3F" to "?":

file:///C:/workspace/_Battery/debug.html%3F172.23.165.1

VS Code version: Code 1.64.0 (5554b12, 2022-02-03T04:22:20.678Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2712)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.83GB (7.30GB free)
Process Argv --crash-reporter-id 87c1d683-95a6-416a-b844-66ab3df3e049
Screen Reader no
VM 0%
Extensions (5)
Extension Author (truncated) Version
vscode-eslint dba 2.2.2
gitlens eam 11.7.0
shortcut-menu-bar jer 3.0.3
hexeditor ms- 1.9.4
vscodeintellicode Vis 1.2.16

(3 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30425749
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30433059
pythonvs932:30410667
vscop940:30404999
vsrem710cf:30416617

@weinand weinand assigned connor4312 and unassigned weinand Feb 4, 2022
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 4, 2022
@connor4312 connor4312 added this to the February 2022 milestone Feb 4, 2022
@connor4312
Copy link
Member

Will be fixed in the next nightly https://github.com/microsoft/vscode-js-debug#nightly-extension

The query string and route fragment will be encoded only if there's a matching file on disk (? is valid in file paths on unix, and # is across platforms.) Otherwise they'll be preserved as before.

@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2022
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Feb 15, 2022
@amunger amunger added the verified Verification succeeded label Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants