Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ComplexNotebookEditorModel and friends #144810

Closed
bpasero opened this issue Mar 10, 2022 · 7 comments · Fixed by #172070
Closed

Remove ComplexNotebookEditorModel and friends #144810

bpasero opened this issue Mar 10, 2022 · 7 comments · Fixed by #172070
Assignees
@amunger @mjbvz
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders perf-bloat
Milestone
January 2023

Comments

@bpasero
Copy link
Member

bpasero commented Mar 10, 2022

If not used anymore.
@rebornix rebornix added the debt Code quality issues label Mar 18, 2022
@bpasero
Copy link
Member Author

bpasero commented Sep 1, 2022

Friendly ping, my understanding is we still carry around old notebook code pre-working-copy times? Why not get rid?

//cc @jrieken

@jrieken
Copy link
Member

jrieken commented Sep 1, 2022

I believe LS is still on the old API but they are inching away from it.

@rebornix
Copy link
Member

rebornix commented Oct 7, 2022

@mjbvz this is what's used by the notebook content provider, once LS moves off the API, we can also remove this.

@kieferrm
Copy link
Member

kieferrm commented Oct 7, 2022

This is blocked by #147248

@mjbvz mjbvz added this to the November 2022 milestone Oct 24, 2022
@jrieken
Copy link
Member

jrieken commented Oct 31, 2022

This can finally happen 👯

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 7, 2022

Still blocked on #163377

@rebornix rebornix modified the milestones: November 2022, December 2022 Nov 23, 2022
@rebornix rebornix mentioned this issue Dec 20, 2022
Closed
@rebornix rebornix assigned amunger and unassigned rebornix Dec 30, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Jan 23, 2023
@mjbvz
Remove remaining parts of complex notebook editor
eff487f 
Fixes microsoft#144810
@mjbvz mjbvz mentioned this issue Jan 23, 2023
Merged
mjbvz added a commit that referenced this issue Jan 23, 2023
@mjbvz
Remove remaining parts of complex notebook editor (#172070)
357db40 
Fixes #144810
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 23, 2023
@jrieken
Copy link
Member

jrieken commented Jan 24, 2023

🥳

@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

@mjbvz mjbvz

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders perf-bloat
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Remove remaining parts of complex notebook editor mjbvz/vscode
7 participants
@rebornix @bpasero @jrieken @amunger @kieferrm @mjbvz @vscodenpa