Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview ruler decorations don't react when the theme changes #145215

Closed
Tyriar opened this issue Mar 16, 2022 · 3 comments · Fixed by #145262
Closed

Overview ruler decorations don't react when the theme changes #145215

Tyriar opened this issue Mar 16, 2022 · 3 comments · Fixed by #145262
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
April 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 16, 2022

We might need to make color mutable on the decoration options?

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Mar 16, 2022
@Tyriar Tyriar added this to the March 2022 milestone Mar 16, 2022
@meganrogge
Copy link
Contributor

This will also need to happen before we can show the currently selected find result (via a different color) so that we don't have to recreate them each time.

meganrogge added a commit that referenced this issue Mar 16, 2022
@meganrogge
fix #145215
ff923a0
@meganrogge meganrogge mentioned this issue Mar 16, 2022
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Mar 24, 2022

This partially works, the canvas doesn't redraw immediately, you need to press enter to update it for example.

@Tyriar Tyriar reopened this Mar 24, 2022
@Tyriar Tyriar modified the milestones: March 2022, April 2022 Mar 24, 2022
@Tyriar Tyriar self-assigned this Mar 24, 2022
@meganrogge
Copy link
Contributor

fixed with #147116

@rzhao271 rzhao271 added the verified Verification succeeded label Apr 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

update overview ruler decoration color when theme colors change microsoft/vscode
4 participants
@Tyriar @rzhao271 @meganrogge and others