Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show message in the terminal when shell integration is disabled by the shell #145583

Closed
meganrogge opened this issue Mar 21, 2022 · 3 comments · Fixed by #145610
Closed

Show message in the terminal when shell integration is disabled by the shell #145583

meganrogge opened this issue Mar 21, 2022 · 3 comments · Fixed by #145610
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration infrastructure, command decorations, etc. verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Milestone
March 2022

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 21, 2022 •
edited
Loading

Pertains to the feedback
Originally posted by @romkatv in #142004 (comment)
@meganrogge meganrogge added feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Mar 21, 2022
@meganrogge meganrogge added this to the April 2022 milestone Mar 21, 2022
@Tyriar Tyriar modified the milestones: April 2022, March 2022 Mar 21, 2022
@Tyriar Tyriar mentioned this issue Mar 21, 2022
Closed
Tyriar added a commit that referenced this issue Mar 21, 2022
@Tyriar
Add VSCODE_SHELL_INTEGRATION
e59c6d6 
Fixes #145583
Fixes #145582
@Tyriar Tyriar mentioned this issue Mar 21, 2022
Merged
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Mar 21, 2022
@hediet hediet added the verification-steps-needed Steps to verify are needed for verification label Mar 23, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Mar 23, 2022

This doesn't seem to work for me?

pwsh shows this:

image

cmd shows nothing? Is it supposed to show shell integration is not enabled?
image

@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2022

Sorry should have added repro steps here, additionally we decided against the warning so this will be covered in the verification of #145582

@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed verification-needed Verification of issue is requested labels Mar 23, 2022
@rzhao271
Copy link
Contributor

I'll add on verification-needed and verified so it doesn't show up in the queries.

@rzhao271 rzhao271 added verified Verification succeeded verification-needed Verification of issue is requested labels Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration infrastructure, command decorations, etc. verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

Successfully merging a pull request may close this issue.

Unset ZDOTDIR before standard scripts run and add VSCODE_SHELL_INTEGRATION microsoft/vscode
6 participants
@Tyriar @hediet @rzhao271 @rchiodo @meganrogge and others