-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the notebook concat text document API proposal #146781
Comments
Yes. we're still consuming this API. |
Actually I don't think we need this anymore as we have our own version: https://github.com/microsoft/lsp-notebook-concat We can just remove this from our list of proposed APIs. |
I don't think we can. lets discuss. |
@mjbvz confirmed, we can remove Jupyter from that list, we'll update our package.json accordingly. |
Thanks @DonJayamanne and @rchiodo! Removing from cc @jrieken |
Confirmed the Dot Net Interactive does not use this API so we can safely delete it. I'll update the api enablement list and then look into deleting the api entirely |
The Notebook Concat Text Document api is not currently on track for finalization. Instead of having this functionality as part of VS Code core, we believe that individual extensions/languages are better equipped to build their own virtual document model of notebooks (in cases where such a model makes sense)
We plan to remove this proposed API once all current consumers have migrated off of it. The only known consumers today are:
Please let me know if you are still consuming this API and if there are any blockers that would prevent migrating off of it
The text was updated successfully, but these errors were encountered: