Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the notebook concat text document API proposal #146781

Closed
2 tasks done
Tracked by #149861
mjbvz opened this issue Apr 4, 2022 · 6 comments
Closed
2 tasks done
Tracked by #149861

Removing the notebook concat text document API proposal #146781

mjbvz opened this issue Apr 4, 2022 · 6 comments
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-api
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 4, 2022

The Notebook Concat Text Document api is not currently on track for finalization. Instead of having this functionality as part of VS Code core, we believe that individual extensions/languages are better equipped to build their own virtual document model of notebooks (in cases where such a model makes sense)

We plan to remove this proposed API once all current consumers have migrated off of it. The only known consumers today are:

Please let me know if you are still consuming this API and if there are any blockers that would prevent migrating off of it

@mjbvz mjbvz added this to the April 2022 milestone Apr 4, 2022
@mjbvz mjbvz self-assigned this Apr 4, 2022
@mjbvz mjbvz changed the title Removing the concat text document proposal Removing the notebook concat text document API proposal Apr 4, 2022
@DonJayamanne
Copy link
Contributor

Please let me know if you are still consuming this API and if there are any blockers that would prevent migrating off of it

Yes. we're still consuming this API.
@rchiodo Please could you update @mjbvz on the status of migrating away from this (I believe Pylance needs to adopt notebook support. But we'd still need this for Jedi)

@rchiodo
Copy link
Contributor

rchiodo commented Apr 5, 2022

Actually I don't think we need this anymore as we have our own version: https://github.com/microsoft/lsp-notebook-concat

We can just remove this from our list of proposed APIs.

@DonJayamanne
Copy link
Contributor

We can just remove this from our list of proposed APIs.

I don't think we can. lets discuss.

@DonJayamanne
Copy link
Contributor

@mjbvz confirmed, we can remove Jupyter from that list, we'll update our package.json accordingly.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 5, 2022

Thanks @DonJayamanne and @rchiodo! Removing from product.json for the next insiders

cc @jrieken

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 14, 2022

Confirmed the Dot Net Interactive does not use this API so we can safely delete it. I'll update the api enablement list and then look into deleting the api entirely

@mjbvz mjbvz added the debt Code quality issues label Apr 14, 2022
@mjbvz mjbvz closed this as completed in 50ea161 Apr 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-api
Projects
None yet
Development

No branches or pull requests

6 participants
@rebornix @DonJayamanne @greazer @mjbvz @rchiodo and others