-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize "simpleUI" debug option #147264
Comments
Anything holding back this from finalization @roblourens? |
No. Could discuss it next month |
Moving this to July based on discussions from last week |
Last month we discussed breaking this into multiple specific flags. This could look like: export interface DebugSessionOptions {
debugUI?: {
/**
* Whether to show the debug toolbar for this debug session. Defaults to true.
*/
showDebugToolbar?: boolean;
/**
* Whether the window statusbar color should be changed to indicate an active debug session. Defaults to true.
*/
useDebugStatusbarColor?: boolean;
/**
* Whether to prevent the debug viewlet from being automatically revealed.
* When false or undefined, this behavior is determined by the setting `debug.openDebug`.
*/
suppressOpenDebugView?: boolean;
};
} |
Today, talked about using flags where false/undefined matches the default: export interface DebugSessionOptions {
debugUI?: {
/**
* Whether to hide the debug toolbar for this debug session
*/
hideDebugToolbar?: boolean; // Can also use suppressDebugToolbar for consistency
/**
* By default vscode will change the window statusbar color to indicate an active debug session. Set this option to disable this behavior.
*/
suppressDebugStatusbarColor?: boolean;
/**
* Whether to prevent the debug viewlet from being automatically revealed.
* When false or undefined, this behavior is determined by the setting `debug.openDebug`.
*/
suppressOpenDebugView?: boolean;
}; |
Maybe inside |
The only thing that bugs me is flooding DebugSessionOptions with a bunch of properties that feel sort of different from the others, and probably won't be commonly used... but I don't have a strong opinion about it |
|
* Finalize notebookDebugOptions API Fix #147264 * Backcompat for the option from vscode-jupyter * Undo comment * Fix build
Added in #128588
Allows to start a debug session which has the debug UI hidden by default. Used for jupyter's Run By Line, and could be useful for other extensions starting atypical-style debug experiences.
The text was updated successfully, but these errors were encountered: