Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: workspace storage closes properly on shutdown #147700

Closed
3 tasks done
bpasero opened this issue Apr 19, 2022 · 0 comments
Closed
3 tasks done

Test: workspace storage closes properly on shutdown #147700

bpasero opened this issue Apr 19, 2022 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Apr 19, 2022

Refs: #114844

Complexity: 2

Create Issue


Previously, anytime you close, reload or change a window, the workspace storage would close and flush. Now, this happens only when you quit the application and is no longer bound to window lifecycle events. The intent is to make window transitions faster by not having to wait for workspace storage to close.

  • open a few windows and accumulate some workspace state such as opened editors
  • trigger lifecycle things in the window (reload, change folder)
  • make sure your workspace state is still there when the window comes back to a workspace you had accumulated state in
  • quit the application
  • start again and verify the state is still there as you left it
@bpasero bpasero added this to the April 2022 milestone Apr 19, 2022
@bpasero bpasero changed the title Test: workspace storage closes on shutdown Test: workspace storage closes properly on shutdown Apr 19, 2022
@dbaeumer dbaeumer removed their assignment Apr 26, 2022
@connor4312 connor4312 removed their assignment Apr 26, 2022
@deepak1556 deepak1556 removed their assignment Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants