Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip restore editors from previous session from crash dialog #114844

Closed
Matthijz98 opened this issue Jan 23, 2021 · 4 comments
Closed

Allow to skip restore editors from previous session from crash dialog #114844

Matthijz98 opened this issue Jan 23, 2021 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan workbench-state UI state across restarts
Milestone

Comments

@Matthijz98
Copy link

  • VSCode Version: 1.52.1
  • OS Version: Windows 10 20H2

Steps to Reproduce:

  1. Open a file that is to big for your ram
  2. VS code wil crashes with this error:
    image
  3. Click on of the options
  4. VS code closes when I reopen it tryes it al again
  5. Closing the file while it is loading it does not work

I would be nice to have a option "close file"

Does this issue occur when all extensions are disabled?: Yes

@bpasero bpasero changed the title OOM crashing loop Do not attempt to reopen files that lead to a crash in previous session Jan 24, 2021
@bpasero bpasero added workbench-state UI state across restarts feature-request Request for new features or functionality labels Jan 24, 2021
@bpasero bpasero added this to the Backlog milestone Jan 24, 2021
@bpasero bpasero removed their assignment Jan 24, 2021
@bpasero
Copy link
Member

bpasero commented Jan 24, 2021

Makes sense, slightly related #57585

@bpasero
Copy link
Member

bpasero commented Aug 26, 2021

One idea would be to enrich the crash dialog with a checkbox that then would offer the user a way to disable restoring editors. By default we would restore editors but when this results in a crash again, the user could make a choice there.

Implementation wise this would probably need to be wired in from the main side here:

private async onWindowError(type: WindowError, details?: { reason: string, exitCode: number }): Promise<void> {

And then I would think we need to delete the memento/workbench.parts.editor key in workspace storage which is the editor view state.

@bpasero bpasero self-assigned this Apr 19, 2022
@bpasero bpasero modified the milestones: Backlog, April 2022 Apr 19, 2022
@bpasero
Copy link
Member

bpasero commented Apr 19, 2022

Added a checkbox to control that:

image

@bpasero bpasero changed the title Do not attempt to reopen files that lead to a crash in previous session Allow to skip restore editors from previous session from crash dialog Apr 19, 2022
meganrogge added a commit that referenced this issue Apr 20, 2022
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Apr 21, 2022
@bpasero bpasero removed the author-verification-requested Issues potentially verifiable by issue author label Apr 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan workbench-state UI state across restarts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@bpasero @Matthijz98 and others