Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting enter in find widget input box cycles through matches backwards #148108

Closed
joyceerhl opened this issue Apr 26, 2022 · 2 comments
Closed
Assignees

Comments

@joyceerhl
Copy link
Contributor

Testing #148060

In a regular text editor, type a query into the find widget and hit enter. Each enter will move the selection forward to the next match.

In the terminal, hitting enter scrolls backward through the terminal output. Additionally, the find widget's <> of <> text does not update to reflect which selection is currently highlighted.

@meganrogge
Copy link
Contributor

This is not new behavior - find previous was called prior to this work when enter is pressed. I believe the reason for this is that we assume people are at the last part of the buffer and therefore want to see the prior result instead of next, which would wrap all the way to the start.

@meganrogge meganrogge added info-needed Issue requires more information from poster and removed info-needed Issue requires more information from poster labels Apr 26, 2022
@meganrogge
Copy link
Contributor

Can repro the label not updating and that's covered by #148136

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants