Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal find result count label #148060

Closed
3 tasks done
meganrogge opened this issue Apr 25, 2022 · 0 comments
Closed
3 tasks done

Test: terminal find result count label #148060

meganrogge opened this issue Apr 25, 2022 · 0 comments

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Apr 25, 2022

Refs #134791

Authors: @meganrogge @Tyriar

Complexity: 3

Create Issue


We have implemented find result count in the terminal in order to align with that in the editor now that we show decorations for the find result.

Screen Shot 2022-04-25 at 9 32 13 AM

At the moment, decorations are a bit costly, so we will avoid showing them and not calculate the result count when there are > 2000 results. This number was chosen based upon when I saw a substantial performance impact.

When we implement decorations differently, via drawing to the canvas instead of inserting DOM elements, this will be resolved.

Verify that when there are:

  • 0 results, No Results is shown
  • Less than 2000 results, the number of results is shown and running findNext and findPrevious updates the currently selected index
  • Greater than or equal to 2000 results, no find result decorations are shown and there is no label in the find widget
@meganrogge meganrogge self-assigned this Apr 25, 2022
@meganrogge meganrogge added this to the April 2022 milestone Apr 25, 2022
@meganrogge meganrogge removed their assignment Apr 25, 2022
@joyceerhl joyceerhl removed their assignment Apr 26, 2022
@isidorn isidorn removed their assignment Apr 26, 2022
@brettcannon brettcannon removed their assignment Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants