Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal find widget decorations are not strong enough #148137

Closed
isidorn opened this issue Apr 26, 2022 · 3 comments
Closed

Terminal find widget decorations are not strong enough #148137

isidorn opened this issue Apr 26, 2022 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2022

Testing #148060

Imho this is not strong enough. Can we double the pixels here?
Or render the whole background in the occurrence color like the editor does.

fyi @misolori

Screenshot 2022-04-26 at 13 33 12

Screenshot 2022-04-26 at 13 39 02

@miguelsolorio
Copy link
Contributor

I filed a similar issue to be more consistent with the editor find widget (when the terminal contrast is turned off) #147013

@isidorn
Copy link
Contributor Author

isidorn commented Apr 26, 2022

Thanks @misolori
I leave it up to Daniel and Megan to close this as dup if needed.

@meganrogge
Copy link
Contributor

/Duplicate #147013

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants
@isidorn @Tyriar @meganrogge @miguelsolorio and others