Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming in file in explorer does not rename its reference in markdown #148146

Closed
isidorn opened this issue Apr 26, 2022 · 2 comments · Fixed by #157209 or #163378
Closed

Renaming in file in explorer does not rename its reference in markdown #148146

isidorn opened this issue Apr 26, 2022 · 2 comments · Fixed by #157209 or #163378
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues on-testplan
Milestone
October 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2022

Testing #147738

  1. Open the following file in markdown https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/June_2016.md#L22
  2. Add the following content
[link](./July_2016.md)
  1. Open Explorer, rename the file July_2016.md. The link in markdown does not get updated 🐛
@mjbvz mjbvz mentioned this issue Apr 30, 2022
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 30, 2022

Hm, thought I already had a feature request tracking this but perhaps I repurposed that issue

Yes this is not expected to work today as the rename provider is not involved at all in this flow. I'd expected rename on files to work much like how it does for JS/TS

@mjbvz mjbvz added feature-request Request for new features or functionality markdown Markdown support issues labels Apr 30, 2022
@mjbvz mjbvz added this to the May 2022 milestone Apr 30, 2022
@mjbvz mjbvz modified the milestones: May 2022, June 2022 May 19, 2022
@mjbvz mjbvz modified the milestones: June 2022, On Deck Jun 7, 2022
@mjbvz mjbvz modified the milestones: On Deck, August 2022 Aug 5, 2022
@mjbvz mjbvz mentioned this issue Aug 5, 2022
Merged
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 9, 2022

Reopening since the feature is still experimental

@mjbvz mjbvz reopened this Aug 9, 2022
diegoVasquez600 pushed a commit to diegoVasquez600/vscode that referenced this issue Aug 9, 2022
@mjbvz
Add experimental support for update markdown links on file moves/rena…
8bf8281 
…mes (microsoft#157209)

* Add experimental support for update markdown links on file moves/renames

Fixes microsoft#148146

This adds a new experimental setting that automatically updates markdown

Note that this needs a new version of the vscode-markdown-languageservice so the build is expected to break for now

* Pick up new LS version
joyceerhl pushed a commit that referenced this issue Aug 10, 2022
@mjbvz @joyceerhl
Add experimental support for update markdown links on file moves/rena…
04c65bf 
…mes (#157209)

* Add experimental support for update markdown links on file moves/renames

Fixes #148146

This adds a new experimental setting that automatically updates markdown

Note that this needs a new version of the vscode-markdown-languageservice so the build is expected to break for now

* Pick up new LS version
@mjbvz mjbvz mentioned this issue Aug 17, 2022
Closed
3 tasks
@mjbvz mjbvz modified the milestones: August 2022, September 2022 Aug 17, 2022
@mjbvz mjbvz modified the milestones: September 2022, October 2022 Sep 21, 2022
@mjbvz mjbvz changed the title Renaming in file in explorer does not rename it's reference in markdown Renaming in file in explorer does not rename its reference in markdown Sep 21, 2022
@kieferrm kieferrm mentioned this issue Oct 8, 2022
Closed
77 tasks
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 11, 2022
@mjbvz
Finalize markdown link updating on file move
63cabd8 
Fixes microsoft#148146
@mjbvz mjbvz mentioned this issue Oct 11, 2022
Merged
mjbvz added a commit that referenced this issue Oct 12, 2022
@mjbvz
Finalize markdown link updating on file move (#163378)
e1a373d 
Fixes #148146
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Oct 12, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 12, 2022
@mjbvz mjbvz mentioned this issue Oct 24, 2022
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues on-testplan
Projects
None yet
Milestone
October 2022
3 participants
@isidorn @mjbvz @vscodenpa