Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interpolation coloring in template literal strings when using new JS/TS grammar #14917

Closed
zackschuster opened this issue Nov 3, 2016 · 2 comments
Assignees

Comments

@zackschuster
Copy link

zackschuster commented Nov 3, 2016

  • VSCode Version: 1.7.0 (or pre-1.7 with new grammar extension)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Write a template literal string with interpolation: `test ${var}`
  2. Before the new grammar was introduced, interpolation received special coloring
  3. Post new grammar, interpolation is colored the same as the rest of the string

Personally, I find this far less readable when scanning template strings; I have to look more carefully than before to pick out where I'm interpolating an expression. Is there a way we can return the old coloring while respecting the new design decisions behind the grammar rewrite?

@waderyan
Copy link

waderyan commented Nov 3, 2016

This issue was moved to microsoft/TypeScript-TmLanguage#341

@waderyan
Copy link

waderyan commented Nov 3, 2016

Migrated to grammar repo.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants