Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interpolation coloring in template literal strings when using new JS/TS grammar #341

Closed
waderyan opened this issue Nov 3, 2016 · 6 comments

Comments

@waderyan
Copy link

waderyan commented Nov 3, 2016

From @zackschuster on November 3, 2016 16:18

  • VSCode Version: 1.7.0 (or pre-1.7 with new grammar extension)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Write a template literal string with interpolation: `test ${var}`
  2. Before the new grammar was introduced, interpolation received special coloring
  3. Post new grammar, interpolation is colored the same as the rest of the string

Personally, I find this far less readable when scanning template strings; I have to look more carefully than before to pick out where I'm interpolating an expression. Is there a way we can return the old coloring while respecting the new design decisions behind the grammar rewrite?

Copied from original issue: microsoft/vscode#14917

@mhegazy
Copy link
Contributor

mhegazy commented Nov 3, 2016

this is what i see now:
image

what is the desired behavior?

@zackschuster
Copy link

The desired behavior colors the interpolation tags to be blue:

image

@ghost
Copy link

ghost commented Nov 4, 2016

Hey,

Believe I am seeing what @waderyan is seeing (image below) in a pure JS project on MacOS 10.12.1 running VSCode 1.7.1.

screen shot 2016-11-04 at 06 40 25

Thanks
Dan :)

@sheetalkamat
Copy link
Member

There was already microsoft/vscode#13166 to track this which seems to be closed. @aeschli can you please take a look and see whats going on here. Our grammar has already scoped out the punctuations.. is there something I am missing

@aeschli
Copy link

aeschli commented Nov 7, 2016

I pushed a fix for VSCode. See microsoft/vscode#13166. Ok to close.

@mhegazy mhegazy closed this as completed Nov 7, 2016
@zackschuster
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants