-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow interpolation coloring in template literal strings when using new JS/TS grammar #341
Comments
Hey, Believe I am seeing what @waderyan is seeing (image below) in a pure JS project on MacOS 10.12.1 running VSCode 1.7.1. Thanks |
There was already microsoft/vscode#13166 to track this which seems to be closed. @aeschli can you please take a look and see whats going on here. Our grammar has already scoped out the punctuations.. is there something I am missing |
I pushed a fix for VSCode. See microsoft/vscode#13166. Ok to close. |
Thank you! |
From @zackschuster on November 3, 2016 16:18
Steps to Reproduce:
`test ${var}`
Personally, I find this far less readable when scanning template strings; I have to look more carefully than before to pick out where I'm interpolating an expression. Is there a way we can return the old coloring while respecting the new design decisions behind the grammar rewrite?
Copied from original issue: microsoft/vscode#14917
The text was updated successfully, but these errors were encountered: