Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on window.experimental.titleMenu #149434

Closed
gjsjohnmurray opened this issue May 13, 2022 · 5 comments
Closed

Feedback on window.experimental.titleMenu #149434

gjsjohnmurray opened this issue May 13, 2022 · 5 comments
Assignees
Milestone

Comments

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented May 13, 2022

Issue Type: Feature Request

Trying out this experimental feature and liking what I see so far.

A couple of points about the magnifier button on the right of the new field:

  1. Tooltip says "Quick Pick". Is this text a placeholder waiting for something better?

  2. For consistency the "Show All Commands" option should probably have an ellipsis.

  3. I also wonder if "Find Command..." or "Run Command..." would be clearer. Or be consistent with the gearwheel menu on the Activity Bar and label it "Command Palette..."

  4. Maybe append keybindings to these entries as a way of teaching people what they are.

image

VS Code version: Code - Insiders 1.68.0-insider (113287c, 2022-05-13T05:15:42.124Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

/assign @jrieken

@gjsjohnmurray
Copy link
Contributor Author

/assign @jrieken

@jrieken
Copy link
Member

jrieken commented May 13, 2022

Thanks for early feedback. With #149441 the search menu will be removed again. The title menu (input-like thing) will show a chevron that invoke "quick pick help", like so

Screen.Recording.2022-05-13.at.12.12.22.mov

What do you think? Makes sense?

@jrieken jrieken added this to the May 2022 milestone May 13, 2022
@jrieken
Copy link
Member

jrieken commented May 13, 2022

Maybe append keybindings to these entries as a way of teaching people what they are.

That's still valid and we should show keybindings when using ? mode with quick pick

@gjsjohnmurray
Copy link
Contributor Author

Makes good sense. I'm following #149445 so you may want to close this one.

@jrieken
Copy link
Member

jrieken commented May 16, 2022

check

@jrieken jrieken closed this as completed May 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants