Add a command palette launcher to the title bar

[jrieken]

The quick pick family, command palette, search etc, is very powerful but often overlooked. Esp new users don't know about its keybindings are rarely discover it. The idea is to render a "launcher" in the title bar part that simply triggers quick pick, like so

Screen.Recording.2022-05-13.at.12.12.22.mov

This is related to #115641

[jrieken]

explore/experiment for May, configuration option for insiders: window.experimental.titleMenu

[jrieken]

/cc @daviddossett @misolori

[jrieken]

I guess we should also consider to update the height of the title bar part, right? This is how it could look with some extra height

[jrieken]

With #149468 I have added support for custom hover here. @sbatten if this sticks we should also do the same for the layout switcher

[jrieken]

Screen.Recording.2022-05-13.at.15.28.03.mov

[daviddossett]

I guess we should also consider to update the height of the title bar part, right? This is how it could look with some extra height

How would this look on Windows or other platforms w/ the classic menu? Would those be centered vertically?

Overall I think it's a good idea. Things feel quite tight as is—although some will prefer that. It could be interesting to think about different height settings if this setting is enabled. However that could be a bit tricky with the existing menu bar style setting being an added dimension here.

Are we able to align the window actions vertically on macOS? Ours are still aligned to the top of the container:

Here's how they look centered in some other native/electron apps:

Safari

Slack

Outlook

[jrieken]

Are we able to align the window actions vertically on macOS? Ours are still aligned to the top of the container:

I would hope so but idk where that currently comes from...

[sbatten]

@jrieken we can control that with trafficLightPosition on BrowserWindow https://www.electronjs.org/docs/latest/api/browser-window

vscode/src/vs/platform/windows/electron-main/window.ts

Lines 244 to 249 in 2dff5de

	if (useCustomTitleStyle) {
	options.titleBarStyle = 'hidden';
	this.hiddenTitleBarStyle = true;
	if (!isMacintosh) {
	options.frame = false;
	}

[imthenachoman]

Reading this thread, I'm a bit confused. Was this option added? I can't find it in the settings but I see it in y'all's screenshots?

[jrieken]

#149445 (comment)

[imthenachoman]

I see. I will download insider build. Thank you.

One feedback, window.experimental.titleMenu is a bit ambiguous and confusing. window.experimental.titleMenuSearch orr something would be a more obvious setting.

[jrieken]

Yeah, we haven't decided how to name this thing yet. The current favourite is "command center"

[imthenachoman]

Sometimes I spend more time figuring out how to name my variables/settings then actually writing the code. It's such an existential philosophical challenge. Good luck! Love this feature. Thanks!

[heartacker]

now we could click the textbox to launch global search.
and we could click the combo box style to get more action,
I suggest adding another button to launching the command panel directly

[jrieken]

Closing as the main part of the feature has been implemented. More feedback is very welcome but should be filed as new issues. Issues in this feature-area a label command-center

[jrieken]

To verify:

• ensure the window.commandCenter-setting toggles the command center