Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titlebar launcher input text overflows on small window sizes #149483

Closed
daviddossett opened this issue May 13, 2022 · 3 comments · Fixed by #149637
Closed

Titlebar launcher input text overflows on small window sizes #149483

daviddossett opened this issue May 13, 2022 · 3 comments · Fixed by #149637
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@daviddossett
Copy link
Contributor

Trying #149445

Perhaps we could default to some subset of the prompt text under some media query or other window size condition. One possible option would be to shorten the [Action | Folder name] pattern to just the action. E.g. "Search hello-world" -> "Search"

Before

CleanShot 2022-05-13 at 09 59 13@2x

After

CleanShot 2022-05-13 at 10 03 30@2x

cc @lychung7 @misolori for other ideas

@jrieken jrieken added this to the May 2022 milestone May 16, 2022
@jrieken
Copy link
Member

jrieken commented May 16, 2022

Small update: based on standup-feedback I swapped "Search" with the corresponding icon. That should give some more room but the problem still exists... I lean towards using the usual ellipsis for text overflow

Screenshot 2022-05-16 at 14 02 46

@jrieken
Copy link
Member

jrieken commented May 16, 2022

This is how it looks with ellipsis. *it actually looks better - the recording shows some padding issues when space is tight

Screen.Recording.2022-05-16.at.14.29.48.mov

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 16, 2022
@daviddossett
Copy link
Contributor Author

Looks great! Especially if there more padding L/R per your edit.

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants