Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote-WSL Getting Started: Tip not translated #150836

Closed
chrmarti opened this issue May 31, 2022 · 1 comment · Fixed by #155081
Closed

Remote-WSL Getting Started: Tip not translated #150836

chrmarti opened this issue May 31, 2022 · 1 comment · Fixed by #155081
Assignees
@lramos15
Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2022

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented May 31, 2022 •
edited
Loading

Testing microsoft/vscode-remote-release#6770

Tip in Getting Strated is not translated:

image (3)

Same under "Tools Installieren" and "Ausfuehren und Debuggen".
@aeschli
Copy link
Contributor

aeschli commented May 31, 2022

The string comes from here:

vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts

Line 1190 in fbbcdc9

container.appendChild($('span.shortcut-message', {}, 'Tip: Use keyboard shortcut ', $('span.keybinding', {}, keybindingLabel)));

@aeschli aeschli removed their assignment May 31, 2022
@aeschli aeschli transferred this issue from microsoft/vscode-remote-release May 31, 2022
@lramos15 lramos15 added the bug Issue identified by VS Code Team member as probable bug label Jul 13, 2022
@lramos15 lramos15 added this to the July 2022 milestone Jul 13, 2022
lramos15 added a commit that referenced this issue Jul 13, 2022
@lramos15
Fix #150836
bc4e63e
@lramos15 lramos15 mentioned this issue Jul 13, 2022
Merged
lramos15 added a commit that referenced this issue Jul 13, 2022
@lramos15
Fix #150836 (#155081)
a03ebca
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 13, 2022
Yoyokrazy pushed a commit to Yoyokrazy/vscode that referenced this issue Jul 13, 2022
@lramos15
Fix microsoft#150836 (microsoft#155081)
6414066
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 14, 2022
andreamah pushed a commit that referenced this issue Jul 14, 2022
@lramos15 @andreamah
Fix #150836 (#155081)
fc074df
jrieken pushed a commit that referenced this issue Jul 18, 2022
@lramos15 @jrieken
Fix #150836 (#155081)
0bb1067
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Jul 27, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Fix #150836 microsoft/vscode
6 participants
@lramos15 @aeschli @rzhao271 @chrmarti @joyceerhl @vscodenpa