Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make beautification an title bar action instead of a notification #151410

Closed
connor4312 opened this issue Jun 7, 2022 · 4 comments · Fixed by microsoft/vscode-js-debug#1295
Closed

Make beautification an title bar action instead of a notification #151410

connor4312 opened this issue Jun 7, 2022 · 4 comments · Fixed by microsoft/vscode-js-debug#1295
Assignees
@connor4312
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2022

Comments

@connor4312
Copy link
Member

Now that we have title bar actions, beautification should be one of those icons instead of a relatively-intrusive notification. In fact we could just show it on all non-sourcemapped code rather than using our more complex detection logic.

/cc @jrieken
@connor4312 connor4312 added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jun 7, 2022
@connor4312 connor4312 added this to the June 2022 milestone Jun 7, 2022
@connor4312 connor4312 self-assigned this Jun 7, 2022
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Jun 7, 2022
@connor4312
feat: simplify pretty print to align with devtools
3eeb048 
Fixes microsoft/vscode#151410
@connor4312 connor4312 mentioned this issue Jun 7, 2022
Merged
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Jun 28, 2022
@jrieken
Copy link
Member

jrieken commented Jun 28, 2022

Not seeing it...

@jrieken jrieken added the verification-steps-needed Steps to verify are needed for verification label Jun 28, 2022
@jrieken
Copy link
Member

jrieken commented Jun 28, 2022

Not seeing it...

Actually seeing the old thing

Screenshot 2022-06-28 at 18 17 42

@jrieken jrieken reopened this Jun 28, 2022
@jrieken jrieken removed the verification-steps-needed Steps to verify are needed for verification label Jun 28, 2022
@connor4312
Copy link
Member Author

@jrieken please verify using the nightly debugger build, as my version bump PR didn't get a review in time for the build

@jrieken jrieken added the verified Verification succeeded label Jun 29, 2022
@jrieken
Copy link
Member

jrieken commented Jun 29, 2022

Seeing it now, like ❤️

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

feat: simplify pretty print to align with devtools microsoft/vscode-js-debug
2 participants
@jrieken @connor4312