-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow easy toggling between sourcemaps and compiled code in js-debug #151412
Comments
Editor title action might be too prominent. Why not Call Stack title area action? I think extensions can not contribute to this place right now, but we could change this. fyi @roblourens for ideas. |
Because it isn't an action that operates on call stacks but on the whole file/editor? |
I think this would operate on the whole debug session, not one editor. That makes me think it would make more sense as a context menu item on the debug session. I also don't think this will be commonly used enough to have a button for it. But, it should be really obvious somehow that this mode is activated. |
Also, you can maintain your own launch configs in a workspace config, I do this sometimes. But I get that it's a pain to clone our huge vscode launch.json |
We could have a context menu action on the debug session, and then when the sourcemapless mode is active put a button in the debug toolbar to turn it back off. |
@connor4312 sounds good to me. |
@jrieken wanted the ability to easily disable sourcemaps in js-debug, and mentioned @alexdima and @bpasero also like debugging without sourcemaps. However, changing this in the launch config via
sourceMap: true/false
is burdensome and makes the decision for the whole team, where it should be a user choice.He suggested a some button (an editor action? is that too prominent?) to toggle sourcemaps on off.
The text was updated successfully, but these errors were encountered: