Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons missing from extension trees with resource uris #152036

Closed
alexr00 opened this issue Jun 14, 2022 · 1 comment · Fixed by #152050
Closed

Icons missing from extension trees with resource uris #152036

alexr00 opened this issue Jun 14, 2022 · 1 comment · Fixed by #152050
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
May 2022 Recovery 1

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 14, 2022

microsoft/vscode-cmake-tools#2595

To reproduce:

  1. Run the tree-view-sample from microsoft/vscode-extension-samples.
  2. Open a folder.
  3. Look at the File Explorer view and see that there are no icons
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues labels Jun 14, 2022
@alexr00 alexr00 added this to the May 2022 Recovery 1 milestone Jun 14, 2022
@alexr00 alexr00 self-assigned this Jun 14, 2022
alexr00 added a commit that referenced this issue Jun 14, 2022
@alexr00
Icons missing from extension trees with resource uris
44a4455 
Fixes #152036
@alexr00 alexr00 mentioned this issue Jun 14, 2022
Merged
alexr00 added a commit that referenced this issue Jun 14, 2022
@alexr00
Icons missing from extension trees with resource uris (#152039)
30d9c6c 
Fixes #152036
alexr00 added a commit that referenced this issue Jun 14, 2022
@alexr00
Icons missing from extension trees with resource uris (#152039)
76ccb81 
Fixes #152036
This was referenced Jun 14, 2022
Merged
Closed
alexr00 added a commit that referenced this issue Jun 14, 2022
@alexr00
Icons missing from extension trees with resource uris (#152039) (#152050
b265e08 
)

Fixes #152036
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 14, 2022
@joaomoreno joaomoreno added the verified Verification succeeded label Jun 15, 2022
@joaomoreno
Copy link
Member

On 30d9c6c:

image

@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
May 2022 Recovery 1
Development

Successfully merging a pull request may close this issue.

Icons missing from extension trees with resource uris (#152039) microsoft/vscode
3 participants
@joaomoreno @alexr00 @vscodenpa