Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Standard shell integration protocol support #153400

Closed
2 tasks done
Tyriar opened this issue Jun 27, 2022 · 4 comments
Closed
2 tasks done

Test: Standard shell integration protocol support #153400

Tyriar opened this issue Jun 27, 2022 · 4 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2022

Refs: #146587

Complexity: 3
Roles: Developer, Engineering Manager
Authors: @Tyriar, @meganrogge

Create Issue


The terminal now supports a degraded shell integration experience where the more standard shell integration protocol used by other terminal is only possible. This was done primarily to support powerlevel10k. To test:

  • Install zsh
  • Install oh-my-zsh
  • Install and configure powerlevel10k
  • Add the following to your .zshrc before .p10k.zsh is sourced:
    ITERM_SHELL_INTEGRATION_INSTALLED=Yes
  • Shell integration's extracting command positions should now work but not the actual commands. This means command navigation (ctrl/cmd+up/down) should work but not rerunning the command via the command decoration for example.
@felipecrs
Copy link
Contributor

felipecrs commented Jul 11, 2022

I would correct the snippet to:

if [[ "$TERM_PROGRAM" == "vscode" ]]; then
  ITERM_SHELL_INTEGRATION_INSTALLED="Yes"
fi

@Tyriar
Copy link
Member Author

Tyriar commented Jul 11, 2022

@felipecrs that's a bit of a hack though, p10k should do this automatically soon. By all means use that in the meantime though.

@felipecrs
Copy link
Contributor

Sure. Thank you. I also found several issues with the manual installation procedure (although I realized that it's not required for P10k with this workaround). I shall send a PR to the docs soon to iron it out.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 11, 2022

@felipecrs any insights about manual installation would be great, FYI it should be greatly improved soon so depending on what it is you may be better off commenting on #153921 rather than doing a PR.

felipecrs added a commit to felipecrs/dotfiles that referenced this issue Jul 11, 2022
At least in simplified mode, as it's the supported option for now.

Refs microsoft/vscode#153400
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants