Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'No elements found' overlaps with source control button #153612

Closed
mjbvz opened this issue Jun 28, 2022 · 2 comments · Fixed by #152481
Closed

'No elements found' overlaps with source control button #153612

mjbvz opened this issue Jun 28, 2022 · 2 comments · Fixed by #152481
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 28, 2022

Issue Type: Bug

  1. Open scm view
  2. Start typing to filter down list of commits

bug

The no elements found overlaps with the commit button

Screen Shot 2022-06-28 at 3 18 42 PM

VS Code version: Code - Insiders 1.69.0-insider (Universal) (e775136, 2022-06-28T05:17:52.688Z)
OS version: Darwin x64 21.5.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 11, 6, 5
Memory (System) 32.00GB (0.09GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@joaomoreno joaomoreno assigned lszomoru and unassigned joaomoreno Jun 29, 2022
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jun 29, 2022
@lszomoru lszomoru added this to the June 2022 milestone Jun 29, 2022
@lszomoru
Copy link
Member

@joaomoreno, I see that the DOM element for the message has a CSS class that has a top padding of 40px hardcoded. This is enough in case there is no action button but it clearly does not work in case we have one. Should we got for a tactical fix to just increase the padding, even though this is also used in other trees?

@joaomoreno
Copy link
Member

Let's not do anything here. I plan on nuking this message with #146806

@lszomoru lszomoru modified the milestones: June 2022, Backlog Jun 30, 2022
@joaomoreno joaomoreno modified the milestones: Backlog, July 2022 Jul 15, 2022
@lszomoru lszomoru modified the milestones: July 2022, Backlog Jul 18, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, July 2022 Jul 25, 2022
@andreamah andreamah added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants