Support find widget in lists/trees #152481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR replaces the existing list/tree type filter:
with an bona fide find widget:
While a seemingly simple change, this has some (desired) consequences when searching/filtering in trees. Namely:
A
will focus the next element which starts withA
./
command will trigger simple keyboard navigation, as opposed to opening the find widget. The VIM extension has the option to change this behavior themselves. cc @J-FieldsChanges
We've taken the opportunity to reframe and rephrase the feature along with all its settings/commands/context keys. Notice that all old names will be marked as deprecated but still be respected for a while, until enough time has passed for extensions to migrate to the new ones.
In general:
Settings
workbench.list.keyboardNavigation
has been renamed toworkbench.list.defaultFindMode
workbench.list.automaticKeyboardNavigation
has been deletedCommands
list.toggleKeyboardNavigation
has been renamed tolist.triggerTypeNavigation
list.find
has been addedlist.closeFind
has been addedlist.toggleFilterOnType
has been renamed tolist.toggleFindMode
Context Keys
Mainly used by the vim extension:
listSupportsKeyboardNavigation
has been renamed tolistSupportsTypeNavigation
listAutomaticKeyboardNavigation
has been renamed tolistTypeNavigationMode
Pending Items
Fixes #70646
Fixes #146806
Fixes #153612
cc @misolori