Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support semi-circle powerline symbols #154324

Closed
Tyriar opened this issue Jul 7, 2022 · 4 comments · Fixed by #154557
Closed

Support semi-circle powerline symbols #154324

Tyriar opened this issue Jul 7, 2022 · 4 comments · Fixed by #154557
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2022

@sbatten fixed in xterm.js: xtermjs/xterm.js#3891

Need to update xterm to pull it in:

image
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed terminal-rendering labels Jul 7, 2022
@Tyriar Tyriar added this to the July 2022 milestone Jul 7, 2022
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Jul 7, 2022
Tyriar added a commit that referenced this issue Jul 8, 2022
@Tyriar
Update xterm
b813ee1 
Fixes #154324
@Tyriar Tyriar mentioned this issue Jul 8, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 8, 2022
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jul 22, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Jul 27, 2022
@rzhao271
Copy link
Contributor

What's a way to verify this issue on Windows?

@sbatten
Copy link
Member

sbatten commented Jul 27, 2022 •
edited
Loading

With Powershell on Windows in the integrated terminal without a powerline font enabled:

Write-Host "`u{e0b4} `u{e0b5} `u{e0b6} `u{e0b7}"

You should get something like this:
image

@rzhao271
Copy link
Contributor

They seem a bit clipped to me:
Screenshot showing the semi-circle powerline symbols are clipped a bit on the right side

@rzhao271 rzhao271 added the verified Verification succeeded label Jul 27, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Aug 3, 2022

@rzhao271 tracked in #156988

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Update xterm
bcb14cc 
Fixes microsoft#154324
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Update xterm microsoft/vscode
5 participants
@Tyriar @sbatten @rzhao271 @meganrogge @vscodenpa