Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize the notebook workspace edit API #155245

Closed
Tracked by #149861
mjbvz opened this issue Jul 14, 2022 · 0 comments · Fixed by #159613
Closed
Tracked by #149861

Finalize the notebook workspace edit API #155245

mjbvz opened this issue Jul 14, 2022 · 0 comments · Fixed by #159613
Assignees
@mjbvz
Labels
api-finalization insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
September 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 14, 2022

Tracks finalizing the notebookWorkspaceEdit api proposal

The old notebookEditorEdit api proposal will not be finalized (#149181)
@mjbvz mjbvz added this to the August 2022 milestone Jul 14, 2022
@mjbvz mjbvz self-assigned this Jul 14, 2022
@mjbvz mjbvz mentioned this issue Jul 14, 2022
Closed
9 tasks
@jrieken jrieken modified the milestones: August 2022, September 2022 Aug 16, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 30, 2022
@mjbvz
Finalize notebookWorkspaceEdit api
2bfc9f2 
Fixes microsoft#155245
@mjbvz mjbvz mentioned this issue Aug 30, 2022
Merged
mjbvz added a commit that referenced this issue Aug 30, 2022
@mjbvz
Finalize notebookWorkspaceEdit api (#159613)
1895178 
Fixes #155245
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 30, 2022
@mjbvz mjbvz mentioned this issue Sep 26, 2022
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api-finalization insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Finalize notebookWorkspaceEdit api mjbvz/vscode
3 participants
@jrieken @mjbvz @vscodenpa