Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem matcher is not added to reconnected VS Code build task #156294

Closed
alexr00 opened this issue Jul 26, 2022 · 0 comments · Fixed by #156699
Closed

Problem matcher is not added to reconnected VS Code build task #156294

alexr00 opened this issue Jul 26, 2022 · 0 comments · Fixed by #156699
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Milestone
August 2022

Comments

@alexr00
Copy link
Member

alexr00 commented Jul 26, 2022

Testing #155349

  1. Open selfhost setup
  2. Run the VS Code - Build task
  3. Also run the Web Ext - Build task
  4. Reload
  5. A problem matcher is used for Web Ext Build, but no the Core - Build and Ext - Build tasks, which you can see because the Web Ext - Build task has a spinner and the other 2 do not. In fact, since there's only a "1" next to the tools icon in the status bar, it looks like the Core - Build and Ext - Build tasks are not reconnected at all.
@rebornix rebornix mentioned this issue Jul 26, 2022
Closed
3 tasks
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-persistence Relating to process reconnection or process revive labels Jul 26, 2022
@meganrogge meganrogge added this to the August 2022 milestone Jul 26, 2022
@meganrogge meganrogge mentioned this issue Aug 1, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 2, 2022
@alexr00 alexr00 added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-persistence Relating to process reconnection or process revive verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

fix task reconnection issues microsoft/vscode
4 participants
@Tyriar @meganrogge @alexr00 @vscodenpa