Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix task reconnection issues #156699

Merged
merged 7 commits into from
Aug 2, 2022
Merged

fix task reconnection issues #156699

merged 7 commits into from
Aug 2, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 29, 2022 •
edited
Loading

fixes #155163
fixes #156294
fixes #155246
fixes #156292
fixes #156284

@meganrogge meganrogge marked this pull request as draft July 29, 2022 22:14
@vscodenpa vscodenpa added this to the July 2022 milestone Jul 29, 2022
@meganrogge meganrogge modified the milestones: July 2022, August 2022 Jul 29, 2022
@meganrogge meganrogge marked this pull request as ready for review August 1, 2022 17:00
@meganrogge meganrogge requested a review from Tyriar August 1, 2022 17:10
@meganrogge
Copy link
Contributor Author

meganrogge commented Aug 1, 2022 •
edited
Loading

works on Mac but not windows for me atm 🤔
https://user-images.githubusercontent.com/29464607/182229352-61ac35cf-6eef-4061-8877-4bb4369d24bc.mov
maybe something's wrong w my tasks on windows atm bc this shouldn't be platform specific

alexr00
alexr00 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows issues aside, this looks like a good approach!

@meganrogge meganrogge merged commit d2bab15 into main Aug 2, 2022
@meganrogge meganrogge deleted the merogge/task-recon-2 branch August 2, 2022 15:23
@meganrogge meganrogge mentioned this pull request Aug 3, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar left review comments

@alexr00 alexr00 alexr00 approved these changes

@mjbvz mjbvz mjbvz approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
August 2022
5 participants
@meganrogge @Tyriar @mjbvz @alexr00 @vscodenpa