Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate through buffer in reverse on reconnection #157018

Closed
meganrogge opened this issue Aug 3, 2022 · 2 comments
Closed

Iterate through buffer in reverse on reconnection #157018

meganrogge opened this issue Aug 3, 2022 · 2 comments
Assignees
@meganrogge
Labels
debt Code quality issues tasks Task system issues terminal Integrated terminal issues
Milestone
August 2022

Comments

@meganrogge
Copy link
Contributor

This is quite expensive, could a reverse iterator be used instead that searches for the begins pattern?

Originally posted by @Tyriar in #156699 (comment)
@meganrogge
Copy link
Contributor Author

Also don't cache bufferLines

@meganrogge meganrogge self-assigned this Aug 3, 2022
@meganrogge meganrogge added tasks Task system issues debt Code quality issues terminal Integrated terminal issues labels Aug 3, 2022
@meganrogge meganrogge added this to the August 2022 milestone Aug 3, 2022
@meganrogge
Copy link
Contributor Author

fixed w #157126

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
debt Code quality issues tasks Task system issues terminal Integrated terminal issues
Projects
None yet
Milestone
August 2022
Development

No branches or pull requests
1 participant
@meganrogge