Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaces should be included in sticky scrolling #156611

Closed
mjbvz opened this issue Jul 28, 2022 · 0 comments
Closed

Namespaces should be included in sticky scrolling #156611

mjbvz opened this issue Jul 28, 2022 · 0 comments
Assignees
@aiday-mar
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 28, 2022

Testing #156175

  1. Enable sticky scrolling
  2. For the TS:
namespace Foo {
    class Bar {
        zap() {
            //
            //
            //
            //
            //
        }

    }
}

Bug
Notice that the namespace Foo is not included in sticky scrolling. I believe it should be since it is an important part of the file's structure
@aiday-mar aiday-mar added this to the July 2022 milestone Jul 29, 2022
@aiday-mar aiday-mar added bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll labels Jul 29, 2022
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Jul 29, 2022
aiday-mar pushed a commit to aiday-mar/vscode that referenced this issue Jul 29, 2022
Sticks namespace {} to the sticky scroll widget too. Fixes microsoft#…
fb6d56f 
…156611.
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 29, 2022
@alexdima alexdima added the verified Verification succeeded label Jul 29, 2022
alexdima pushed a commit that referenced this issue Aug 2, 2022
Sticky scroll should not cover scrollbar and minimap (fixes #156570) (#…
35ab686 
…156869)

* Sticks namespace {} to the sticky scroll widget too. Fixes #156611.

* No longer need the verification model.getLineContent(start) !== '' with the latest changes. Fixes #156616.

* Set the width of the sticky scroll so the widget is not over the minimap. Works on resize too. Only for minimap placed on the right.

* Sticky scroll should not take into account the vertical scrollbar (takes into account the minimap side as well). Fixes #156570.
@gjsjohnmurray gjsjohnmurray mentioned this issue Aug 3, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aiday-mar aiday-mar

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

No branches or pull requests
4 participants
@alexdima @mjbvz @aiday-mar @vscodenpa