Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky scrolling is broken on multiline function declarations in C #157680

Closed
tristan957 opened this issue Aug 9, 2022 · 2 comments · Fixed by #157466
Closed

Sticky scrolling is broken on multiline function declarations in C #157680

tristan957 opened this issue Aug 9, 2022 · 2 comments · Fixed by #157466
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@tristan957
Copy link

tristan957 commented Aug 9, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.70.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a C file
  2. Create a function declaration and definition that spans 2 lines like so
static void
func(void)
{
  // ...
}

When you scroll through func, the sticky scrolling will use static void instead of func.

image

@niderhoff
Copy link

niderhoff commented Aug 10, 2022

It is also "broken" for Python functions with decorators:

class MyClass:

    def __init__():
        pass

    @staticmethod
    def my_func():
        # here is my
        # function
        pass

image

edit: I guess it will be fixed with #157466 or is that Pull Request only valid for TypeScript?

@aiday-mar
Copy link
Contributor

aiday-mar commented Aug 10, 2022

Thank you for your feedback. This should be fixed by #157466 with @DingWeizhe's contribution.

New behavior:

sticky-scroll-c

And:

sticky-scroll-python

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 10, 2022
@vscodenpa vscodenpa added this to the August 2022 milestone Aug 10, 2022
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 10, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 11, 2022
@aiday-mar aiday-mar added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) insiders-released Patch has been released in VS Code Insiders
Projects
None yet
6 participants