fix sticky scroll start line number #157466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @aiday-mar |
This was referenced Aug 8, 2022
DingWeizhe
force-pushed
the
fix-sitkcy-scroll-start-line-number
branch
from
3d7babc to
3388612
Compare
|
#157483 be merged with lots of changes so I rebase the PR |
|
@DingWeizhe Thank you for your contribution, this will be merged into the existing code base |
alexdima
approved these changes
Aug 10, 2022
This was referenced Aug 10, 2022
This was referenced Aug 10, 2022
joyceerhl
pushed a commit
that referenced
this pull request
Aug 10, 2022
Co-authored-by: dweizhe <d.weizhe@anyong.com.tw>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157680
Fixes #157180
Fixes #157293
Fixes #157380
Fixes #157375
fix #157375
when class or method have decorator(TypeScript) or attribute(C#),
range.startLineNumber is begin of decorator, but selectionRange.startLineNumber is start of method.