Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky scroll support namespace / property / struct #157441

Closed

Conversation

DingWeizhe
Copy link
Contributor

@DingWeizhe DingWeizhe commented Aug 7, 2022

fix #157375

  • support namespace / property / struct.

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Aug 7, 2022

Instead of sticky scroll hardcoding the SymbolKinds it makes sticky, perhaps the language configuration file of the Symbol Provider should declare which kinds are sticky.

Pinging @aiday-mar

@connor4312 connor4312 assigned aiday-mar and unassigned connor4312 Aug 7, 2022
@DingWeizhe DingWeizhe force-pushed the fix-sticky-scroll-decorator branch from dc61727 to 2bc1886 Compare August 8, 2022 02:29
- Namespace / Property / Struct

reorder import
@DingWeizhe DingWeizhe force-pushed the fix-sticky-scroll-decorator branch from 2bc1886 to 17ad94d Compare August 8, 2022 02:30
@DingWeizhe DingWeizhe changed the title sticky scroll support namespace / property / struct & fix startLineNumber when class / method with decorator / attributes sticky scroll support namespace / property / struct Aug 8, 2022
@DingWeizhe
Copy link
Contributor Author

DingWeizhe commented Aug 8, 2022

To discuss the topic more clearly, I split this PR into two PR.
another one here: #157441

@DingWeizhe
Copy link
Contributor Author

In fact, I think it should not be judged against Kind,
Otherwise, it would be difficult to specify what is needed and what is not needed in various programming languages.

@gjsjohnmurray suggestion of letting users customize is a good idea, but I think the list should be a list of disabled kinds, not enabled. otherwise we still need to have a default enabled list for each language.

Also without judging against Kind, in some programming languages (like HTML or JSON) there will be too many lines sticking, which I think can be solved by sticking only the last N lines.

@gjsjohnmurray
Copy link
Contributor

To discuss the topic more clearly, I split this PR into two PR. another one here: #157441

Other PR is actually #157466

@DingWeizhe
Copy link
Contributor Author

To discuss the topic more clearly, I split this PR into two PR. another one here: #157441

Other PR is actually #157466

thanks for the correction

@alexdima alexdima self-requested a review August 8, 2022 19:01
@DingWeizhe
Copy link
Contributor Author

DingWeizhe commented Aug 9, 2022

#157483 solved the problem

@DingWeizhe DingWeizhe closed this Aug 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky Scroll: In C#, namespace, struct, property should stick, attributes shouldn't stick
4 participants