Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM decorations are single pixel wide and sometimes not visible at all #158276

Closed
Tyriar opened this issue Aug 16, 2022 · 7 comments · Fixed by #158786
Closed

SCM decorations are single pixel wide and sometimes not visible at all #158276

Tyriar opened this issue Aug 16, 2022 · 7 comments · Fixed by #158786
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team scm General SCM compound issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 16, 2022

Not sure if this was intentional but it's very small now:

image

They are invisible when zooming out once:

image

Version: 1.71.0-insider (user setup)
Commit: 8e42bda
Date: 2022-08-16T05:18:32.502Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22000
Sandboxed: Yes


I preferred the old style:

image

Version: 1.69.2 (user setup)
Commit: 3b889b0
Date: 2022-07-18T16:12:52.460Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22000

@Tyriar
Copy link
Member Author

Tyriar commented Aug 16, 2022

The mouse target is also 1 pixel wide now

@Tyriar
Copy link
Member Author

Tyriar commented Aug 18, 2022

Deleted lines are much harder to see and use now

image

@miguelsolorio
Copy link
Contributor

do you have any repro steps? I can't seem to see that, assume it was unintentional:

CleanShot 2022-08-18 at 11 42 55

CleanShot 2022-08-18 at 11 43 31

@Tyriar
Copy link
Member Author

Tyriar commented Aug 18, 2022

This is in a PR so likely related to the comments changes

@Tyriar Tyriar added the papercut 🩸 A particularly annoying issue impacting someone on the team label Aug 22, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Aug 22, 2022

Still an issue after #158299 and #158521 fixes:

Recording 2022-08-22 at 07 58 06

@alexr00
Copy link
Member

alexr00 commented Aug 22, 2022

This does seem likely to be related to the comments changes. I'm looking into it.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 22, 2022

I have "editor.folding": false set, it works fine when I enable folding again

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Aug 22, 2022
@alexr00 alexr00 added this to the August 2022 milestone Aug 22, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 22, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders papercut 🩸 A particularly annoying issue impacting someone on the team scm General SCM compound issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants