Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underlines in DOM renderer are not working #158917

Closed
Tyriar opened this issue Aug 23, 2022 · 0 comments · Fixed by #158989
Closed

Underlines in DOM renderer are not working #158917

Tyriar opened this issue Aug 23, 2022 · 0 comments · Fixed by #158989
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering verified Verification succeeded
Milestone
August 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

See #158827 for how to show an underline. We need to update xterm.css
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-rendering labels Aug 23, 2022
@Tyriar Tyriar added this to the August 2022 milestone Aug 23, 2022
meganrogge added a commit that referenced this issue Aug 23, 2022
@meganrogge
fix #158917
27fd00d
@meganrogge meganrogge mentioned this issue Aug 23, 2022
Merged
meganrogge added a commit that referenced this issue Aug 23, 2022
@meganrogge
update xterm.css (#158989)
ea09b02 
fix #158917
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 23, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

update xterm.css microsoft/vscode
4 participants
@Tyriar @rzhao271 @meganrogge @vscodenpa