Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor indicators not accessible by keyboard #159088

Closed
2 of 3 tasks
rzhao271 opened this issue Aug 24, 2022 · 0 comments
Closed
2 of 3 tasks

Settings editor indicators not accessible by keyboard #159088

rzhao271 opened this issue Aug 24, 2022 · 0 comments
Assignees
@rzhao271
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug on-testplan settings-editor VS Code settings editor issues
Milestone
November 2022

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Aug 24, 2022 •
edited
Loading

Currently, the Settings indicators area, which is the area with labels such as "Modified elsewhere", is not accessible by keyboard.

Ideas:

  • Change settings indicators key handling so that one can use arrow keys #167470
  • Change the key event handling so that once focus is on an indicator, the user can use space or enter keys, or Ctrl+K Ctrl+I to show and focus into the hover.
  • Change the appearance of the indicators so that it is more obvious that one can tab to them. Right now, the indicators are shown in plain text, and have underlines when hovered over. Yet, users cannot click on them; they are only supposed to hover over them. Moreover, after enabling tabIndex for them and adding an outline to make it clear when they received focus, because they were plain text, the appearance just seemed off, as though the user was "magically" focusing onto plain text.
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Aug 24, 2022
@rzhao271 rzhao271 added this to the September 2022 milestone Aug 24, 2022
@rzhao271 rzhao271 self-assigned this Aug 24, 2022
This was referenced Aug 24, 2022
Closed
Closed
Closed
@kieferrm kieferrm mentioned this issue Sep 6, 2022
Closed
@rzhao271 rzhao271 modified the milestones: September 2022, October 2022 Sep 26, 2022
@kieferrm kieferrm mentioned this issue Oct 8, 2022
Closed
77 tasks
This was referenced Oct 11, 2022
Closed
Closed
@rzhao271 rzhao271 mentioned this issue Oct 19, 2022
Merged
@rzhao271 rzhao271 modified the milestones: October 2022, November 2022 Oct 21, 2022
@kieferrm kieferrm mentioned this issue Nov 6, 2022
Closed
This was referenced Nov 9, 2022
Merged
Merged
rzhao271 added a commit that referenced this issue Nov 16, 2022
@rzhao271
Switch from setupCustomHover to hoverService
10fe16b 
Ref #159088
By switching to hoverService, we get to customize the hover widget
more for the Settings editor indicators.
rzhao271 added a commit that referenced this issue Nov 16, 2022
@rzhao271
Switch from setupCustomHover to hoverService
dd01fd8 
Ref #159088
By switching to hoverService, we get to customize the hover widget
more for the Settings editor indicators.
rzhao271 added a commit that referenced this issue Nov 17, 2022
@rzhao271
Switch from setupCustomHover to hoverService (#166500)
c3f40b9 
Ref #159088
By switching to hoverService, we get to customize the hover widget
more for the Settings editor indicators.
rzhao271 added a commit that referenced this issue Nov 17, 2022
@rzhao271
Refactor "Modified in: User" indicator
d6c13e3 
Ref #159088
The "Modified in: User" indicator is not like other indicators,
because it doesn't put up a hover,
and it has a link in the label itself.

This PR refactors that indicator and clarifies that
tab focus goes straight to the link when
using keyboard navigation.
rzhao271 added a commit that referenced this issue Nov 17, 2022
@rzhao271
Refactor "Modified in: User" indicator
2064a84 
Ref #159088
The "Modified in: User" indicator is not like other indicators,
because it doesn't put up a hover,
and it has a link in the label itself.

This PR refactors that indicator and clarifies that
tab focus goes straight to the link when
using keyboard navigation.
@rzhao271 rzhao271 mentioned this issue Nov 17, 2022
Merged
rzhao271 added a commit that referenced this issue Nov 17, 2022
@rzhao271
Refactor "Modified in: User" indicator (#166645)
a9f0251 
Ref #159088
The "Modified in: User" indicator is not like other indicators,
because it doesn't put up a hover, and it has a link in the label itself.

This PR refactors that indicator and clarifies that tab focus 
goes straight to the link when using keyboard navigation.
@rzhao271 rzhao271 mentioned this issue Nov 17, 2022
Merged
rzhao271 added a commit that referenced this issue Nov 17, 2022
@rzhao271
Fix hover escape key focus impl
df871dd 
Ref #159088
@rzhao271 rzhao271 mentioned this issue Nov 21, 2022
Merged
rzhao271 added a commit that referenced this issue Nov 21, 2022
@rzhao271
Fix hover escape key focus impl
67271fc 
Ref #159088
@rzhao271 rzhao271 mentioned this issue Nov 22, 2022
Merged
rzhao271 added a commit that referenced this issue Nov 22, 2022
@rzhao271
Migrate over hover CSS rules
edb79a5 
Ref #159088
rzhao271 added a commit that referenced this issue Nov 22, 2022
@rzhao271
Migrate over hover CSS rules (#166921)
c13c915 
Ref #159088
This was referenced Nov 22, 2022
Merged
Merged
rzhao271 added a commit that referenced this issue Nov 22, 2022
@rzhao271
Add missing keydown event handlers
bdf30ec 
Ref #159088
rzhao271 added a commit that referenced this issue Nov 22, 2022
@rzhao271
Fix hover escape key focus impl
8334fa0 
Ref #159088
rzhao271 added a commit that referenced this issue Nov 22, 2022
@rzhao271
Add missing keydown handlers to Settings editor (#167000)
067d6cc 
Add missing keydown event handlers

Ref #159088
@rzhao271 rzhao271 mentioned this issue Nov 23, 2022
Closed
3 tasks
@rzhao271 rzhao271 mentioned this issue Nov 23, 2022
Closed
3 tasks
rzhao271 added a commit that referenced this issue Nov 28, 2022
@rzhao271
Fix hover tabbing behaviour (#166657)
dbe96ec 
Ref #159088

* Focus back to last focused element when tabbing out of hover
* Add focus trap (tab loop) while focused on the hover
rzhao271 added a commit that referenced this issue Nov 28, 2022
@rzhao271
Add keydown handler for rendered markdown strings (#166999)
90e3aea 
Ref #163086
Ref #159088
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
2 participants
@rzhao271 @vscodenpa