Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double pasting webview vscode into input/textarea #161001

Closed
rosticos opened this issue Sep 15, 2022 · 3 comments · Fixed by #178120
Closed

Double pasting webview vscode into input/textarea #161001

rosticos opened this issue Sep 15, 2022 · 3 comments · Fixed by #178120
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders keybindings VS Code keybinding issues linux Issues with VS Code on Linux verified Verification succeeded webview Webview issues
Milestone
April 2023

Comments

@rosticos
Copy link

rosticos commented Sep 15, 2022 •
edited
Loading

When set Russian Language and CTRL + V (paste) pasting double
Use default webview-sample, html > body

<body>
	<img src="${catGifPath}" width="300"
	<textarea></textarea>
	<script nonce="${nonce}" src="${scriptUri}"></script>
</body>

OS: Ubuntu 21.10
VSCode:

1.71.1
e7f30e38c5a4efafeec8ad52861eb772a9ee4dfb
x64

cat
@mjbvz mjbvz added help wanted Issues identified as good community contribution opportunities keybindings VS Code keybinding issues webview Webview issues labels Sep 15, 2022
@Harsh-Singh-Rajput
Copy link

@rosticos I am excited to work on this
Can you assign this to me, also if possible canu guide me please how can i approach to fix this issue?

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2022
@mjbvz mjbvz added this to the Backlog milestone Dec 5, 2022
@Mdbset
Copy link

Mdbset commented Jan 18, 2023

Hey! I have a similar error. Before fixing the error, I used this method to solve the problem by adding the following code to the html:

$(document).ready(function() {
	var ctrlDown = false,
	ctrlKey = 17,
	cmdKey = 91,
	vKey = 86,
	cKey = 67;

	$(document).keydown(function(e) {
		if (e.keyCode == ctrlKey || e.keyCode == cmdKey) ctrlDown = true;
	}).keyup(function(e) {
		if (e.keyCode == ctrlKey || e.keyCode == cmdKey) ctrlDown = false;
	});

	// Document Ctrl + C/V 
	$(document).keydown(function(e) {
		if (ctrlDown && (e.keyCode == vKey)) {
			e.preventDefault();
		}
	});
});

YinDongFang added a commit to YinDongFang/vscode that referenced this issue Mar 23, 2023
@YinDongFang
fix: Double pasting in webview(using russian keyboard layout) (micros…
7f9be14 
…oft#161001)
@YinDongFang YinDongFang mentioned this issue Mar 23, 2023
Merged
mjbvz added a commit that referenced this issue Apr 24, 2023
@YinDongFang @mjbvz
fix: Double pasting in webview(using russian keyboard layout) (#161001)…
4d44426 
… (#178120)

Co-authored-by: Matt Bierner <matb@microsoft.com>
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 24, 2023
@rzhao271 rzhao271 modified the milestones: Backlog, April 2023 Apr 26, 2023
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Apr 27, 2023
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@rosticos, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version d6290ef of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@rzhao271 rzhao271 added verified Verification succeeded linux Issues with VS Code on Linux confirmed Issue has been confirmed by VS Code Team member and removed author-verification-requested Issues potentially verifiable by issue author labels May 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders keybindings VS Code keybinding issues linux Issues with VS Code on Linux verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

fix: Double pasting in webview(using russian keyboard layout) (#161001) YinDongFang/vscode
6 participants
@rzhao271 @mjbvz @rosticos @Mdbset @Harsh-Singh-Rajput @vscodenpa