Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-uri (3.0.5): Incorrect Types #161166

Closed
Jason3S opened this issue Sep 17, 2022 · 1 comment · Fixed by microsoft/vscode-uri#29 · 4 remaining pull requests
Closed

vscode-uri (3.0.5): Incorrect Types #161166

Jason3S opened this issue Sep 17, 2022 · 1 comment · Fixed by microsoft/vscode-uri#29 · 4 remaining pull requests
Assignees

Comments

@Jason3S
Copy link

Jason3S commented Sep 17, 2022

Does this issue occur when all extensions are disabled?: Yes - N/A

NOTE: this is an issue with microsoft/vscode-uri v3.0.5.

It breaks building any TypeScript code dependent upon vscode-uri 3.0.5.

Error: 'Uri' refers to a value, but is being used as a type here. Did you mean 'typeof Uri'?

Something in the build process incorrectly generates the index.d.ts.

index.d.ts 3.0.5

import { URI } from './uri';
import { Utils } from './utils';
export { URI, Utils };

export const { URI, Utils } = LIB;

vs

index.d.ts 3.0.4

import { URI } from './uri';
import { Utils } from './utils';
export { URI, Utils };

image

@Jason3S
Copy link
Author

Jason3S commented Sep 17, 2022

@aeschli, @jrieken

I'm not sure how this change would have broken the build, but something in the build process went wrong.
microsoft/vscode-uri#28

@mjbvz mjbvz assigned aeschli and unassigned mjbvz Sep 17, 2022
Jason3S added a commit to streetsidesoftware/cspell-action that referenced this issue Sep 19, 2022
Jason3S added a commit to streetsidesoftware/cspell-action that referenced this issue Sep 19, 2022
* chore: lock vscode-uri to 3.0.4

To be reverted when microsoft/vscode#161166 is fixed.
aeschli added a commit to microsoft/vscode-uri that referenced this issue Sep 19, 2022
aeschli added a commit to microsoft/vscode-uri that referenced this issue Sep 19, 2022
* vscode-uri (3.0.5): Incorrect Types. Fixes microsoft/vscode#161166

* prepare 3.0.6
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.