Provide better completion for editor.codeActionsOnSave #161284
Labels
editor-code-actions
Editor inplace actions (Ctrl + .)
feature-request
Request for new features or functionality
help wanted
Issues identified as good community contribution opportunities
insiders-released
Patch has been released in VS Code Insiders
on-testplan
Milestone
Currently, when user configure
editor.codeActionsOnSave
, this is what user sees.It basically promotes users to write
"source.fixAll": true
if user wants anyfix all
to run on save.problem is it assumes there is only 1 kind of source.fixAll from an extension. but like
refactor
hasrefactor.extract
,refactor.inline
and etc, one extension can provide multiple kinds of fix all code actions.for example, pylance provides 2 fix all (and plan to add more)
but in current user experience,
source.fixAll: true
basically catch all option. any new fix all added will automatically picked up and run.so, user basically need to check documentation every time when new version is released for extensions and check new
fix all
added and disable them if they don't want them.It would be better if it works the other way around and "editor.codeActionsOnSave" actually show all
fix all codeActions
in completion so that user can enable each specificfix all
they want rather than enableall
and disable each specific one.by the way, I see other extension such as eslint, tslint, stylelint, markdownlint's vscode extension expose only 1
fix all
code action and use its own option to control what fix are run onfix all
and apply them themselves.if that is how it is supposed to work, it would be nice to document that in vscode doc and enforce to have only 1
fix all
code action.but even so, showing each
fix all
kind from each extension should still benefit users in case they want to disablefix all
provider of an extension.The text was updated successfully, but these errors were encountered: